Fix immutability violations and redundant initialization in F1 replay sources

[Copilot]

The F1 replay source classes mutated input FileWatcherOptions instead of returning new instances, and performed redundant double-initialization. Additionally, the debounce delay default logic failed to override the library's 1s default.

Changes

• Immutable options pattern: EnsurePath methods now return new FileWatcherOptions instances instead of mutating the input parameter (F1RaceReplaySource, F12022-2025RaceReplaySource)

• Simplified initialization: Removed redundant EnsurePath call in options-based constructors; ApplyDefaults now handles path defaulting directly

• Fixed debounce delay detection: ApplyDefaults now checks for both default (00:00:00) and library default (1s) to consistently apply F1's 2s default across constructor paths

• Code clarity: Extracted LibraryDefaultDebounceDelay and F1DebounceDelay constants; replaced foreach with LINQ .Select() in path detection

Before

private static FileWatcherOptions EnsurePath(FileWatcherOptions options)
{
    if (string.IsNullOrEmpty(options.Path))
    {
        options.Path = GetDefaultReplayPath();  // Mutates input
    }
    return options;
}

public F12025RaceReplaySource(FileWatcherOptions options)
    : base(ApplyDefaults(EnsurePath(options)))  // Double call
{
}

After

private static FileWatcherOptions EnsurePath(FileWatcherOptions options)
{
    if (string.IsNullOrEmpty(options.Path))
    {
        return new FileWatcherOptions  // Returns new instance
        {
            Path = GetDefaultReplayPath(),
            Patterns = options.Patterns,
            IncludeSubdirectories = options.IncludeSubdirectories,
            DebounceDelay = options.DebounceDelay
        };
    }
    return options;
}

public F12025RaceReplaySource(FileWatcherOptions options)
    : base(ApplyDefaults(options))  // Single call
{
}

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.