Address code review feedback for War Thunder HTTP polling implementation#15
Merged
codegefluester merged 4 commits intofeat/add-war-thunder-realtime-sourcefrom Feb 11, 2026
Merged
Conversation
Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add War Thunder HTTP telemetry integration
Address code review feedback for War Thunder HTTP polling implementation
Feb 11, 2026
codegefluester
approved these changes
Feb 11, 2026
codegefluester
added a commit
that referenced
this pull request
Feb 12, 2026
…ion (#15) * Initial plan * Address code review comments Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Remove redundant TaskCanceledException catch Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Clarify timeout cancellation comment Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 7 code review issues from the War Thunder realtime source PR including broken documentation links, missing using statements, incorrect cancellation handling, and resource disposal issues.
Changes
Cancellation Handling
HttpPollingSourceBaseTaskCanceledExceptioncatch (already handled byOperationCanceledExceptionparent)Resource Management
CaptureWarThunderSessionmatching F1 patternCancellationTokenSourceand unregister event handler in finally blockFileNotFoundExceptionandOperationCanceledExceptionwith user-friendly messagesCompilation Fixes
System,System.Collections.Generic, andSystem.Linqusing statements toHttpPollingSourceOptionsDocumentation
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.