Skip to content

Clean up War Thunder StateSource: remove SkipInvalidFrames and fix code issues#18

Merged
codegefluester merged 2 commits intobugfixes/war-thunder-sourcefrom
copilot/sub-pr-17
Feb 13, 2026
Merged

Clean up War Thunder StateSource: remove SkipInvalidFrames and fix code issues#18
codegefluester merged 2 commits intobugfixes/war-thunder-sourcefrom
copilot/sub-pr-17

Conversation

Copy link
Contributor

Copilot AI commented Feb 13, 2026

Addresses review feedback from PR #17 to simplify the War Thunder StateSource implementation and fix identified code quality issues.

Changes

  • Removed SkipInvalidFrames feature: Eliminated the filtering logic and related properties (SkipInvalidFrames, InvalidFrameLogInterval) from StateSourceOptions and StateSource. All frames are now yielded directly from the HTTP polling base class.

  • Removed unused field: Deleted _lastInvalidFrameLog from StateSource that was declared but never used.

  • Fixed always-false condition: Changed else if (!hasData) to else in HttpPollingSourceBase (line 192 was checking !hasData after already checking hasData in the if branch).

  • Bumped StateData DataVersion: Updated from (1,0,0) to (2,0,0) to reflect the breaking change where Valid field changed from int to bool.

  • Simplified nested conditionals: Combined nested if statements in demo code from:

    if (data.Valid)
    {
        if (frameCount % 1 == 0)
        {
            DrawDashboard(data);
        }
    }

    to:

    if (data.Valid && frameCount % 1 == 0)
    {
        DrawDashboard(data);
    }

The simplified StateSource now just passes through all telemetry data without filtering, making the behavior more predictable and the code easier to maintain.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…taVersion, combine if statements

Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
Copilot AI changed the title [WIP] Update War Thunder structs for inconsistent state endpoint Clean up War Thunder StateSource: remove SkipInvalidFrames and fix code issues Feb 13, 2026
Copilot AI requested a review from codegefluester February 13, 2026 13:58
@codegefluester codegefluester marked this pull request as ready for review February 13, 2026 14:02
@codegefluester codegefluester merged commit c70c1a6 into bugfixes/war-thunder-source Feb 13, 2026
@codegefluester codegefluester deleted the copilot/sub-pr-17 branch February 13, 2026 22:09
github-actions bot pushed a commit that referenced this pull request Feb 13, 2026
- Change StateData.Valid field type from int to bool (breaking change from PR #18)
- Add parameter validation documentation for hz parameter (from PR #16)
- Update troubleshooting section to reference boolean Valid field

This update reflects changes from merged PRs #14, #16, #17, and #18.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions bot pushed a commit that referenced this pull request Feb 13, 2026
- Document breaking change: Valid field changed from int to bool
- Add parameter validation section for hz parameter
- Add breaking changes section at top of document
- Update troubleshooting section to reference boolean type
- Add notes about complete field listings in source files

Addresses changes from PR #18, #16, #17, and #14.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
codegefluester pushed a commit that referenced this pull request Feb 13, 2026
- Document breaking change: Valid field changed from int to bool
- Add parameter validation section for hz parameter
- Add breaking changes section at top of document
- Update troubleshooting section to reference boolean type
- Add notes about complete field listings in source files

Addresses changes from PR #18, #16, #17, and #14.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions github-actions bot mentioned this pull request Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants