Clean up War Thunder StateSource: remove SkipInvalidFrames and fix code issues#18
Merged
codegefluester merged 2 commits intobugfixes/war-thunder-sourcefrom Feb 13, 2026
Merged
Conversation
…taVersion, combine if statements Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update War Thunder structs for inconsistent state endpoint
Clean up War Thunder StateSource: remove SkipInvalidFrames and fix code issues
Feb 13, 2026
codegefluester
approved these changes
Feb 13, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
- Change StateData.Valid field type from int to bool (breaking change from PR #18) - Add parameter validation documentation for hz parameter (from PR #16) - Update troubleshooting section to reference boolean Valid field This update reflects changes from merged PRs #14, #16, #17, and #18. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
- Document breaking change: Valid field changed from int to bool - Add parameter validation section for hz parameter - Add breaking changes section at top of document - Update troubleshooting section to reference boolean type - Add notes about complete field listings in source files Addresses changes from PR #18, #16, #17, and #14. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
codegefluester
pushed a commit
that referenced
this pull request
Feb 13, 2026
- Document breaking change: Valid field changed from int to bool - Add parameter validation section for hz parameter - Add breaking changes section at top of document - Update troubleshooting section to reference boolean type - Add notes about complete field listings in source files Addresses changes from PR #18, #16, #17, and #14. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #17 to simplify the War Thunder StateSource implementation and fix identified code quality issues.
Changes
Removed
SkipInvalidFramesfeature: Eliminated the filtering logic and related properties (SkipInvalidFrames,InvalidFrameLogInterval) fromStateSourceOptionsandStateSource. All frames are now yielded directly from the HTTP polling base class.Removed unused field: Deleted
_lastInvalidFrameLogfromStateSourcethat was declared but never used.Fixed always-false condition: Changed
else if (!hasData)toelseinHttpPollingSourceBase(line 192 was checking!hasDataafter already checkinghasDatain the if branch).Bumped
StateDataDataVersion: Updated from (1,0,0) to (2,0,0) to reflect the breaking change whereValidfield changed frominttobool.Simplified nested conditionals: Combined nested if statements in demo code from:
to:
The simplified StateSource now just passes through all telemetry data without filtering, making the behavior more predictable and the code easier to maintain.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.