Skip to content

Conversation

@jayhack
Copy link
Contributor

@jayhack jayhack commented Jan 29, 2025

Motivation

Content

Testing

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed
  • I have read and agree to the Contributor License Agreement

@jayhack jayhack requested review from a team and codegen-team as code owners January 29, 2025 23:30
@jayhack jayhack requested review from bagel897 and removed request for a team January 29, 2025 23:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jan 29, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1880 1 1879 57
View the top 1 failed tests by shortest run time
tests.unit.codegen.sdk.code_generation.test_api_doc_generation test_mdx_api_doc_generation_sanity@codegen
Stack Traces | 84.8s run time
codebase = <Codebase(name=codegen-sdk, language=PYTHON, path=/codegen-sdk)>

    @pytest.mark.timeout(120)
    @pytest.mark.xdist_group("codegen")
    def test_mdx_api_doc_generation_sanity(codebase) -> None:
>       docs_json = generate_docs_json(codebase, "HEAD")

.../sdk/code_generation/test_api_doc_generation.py:53: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
.../code_generation/doc_utils/generate_docs_json.py:156: in generate_docs_json
    method_doc = process_method(method, cls, cls_doc, seen_methods)
.../code_generation/doc_utils/generate_docs_json.py:74: in process_method
    parsed_param.type = replace_multiple_types(
.../code_generation/doc_utils/utils.py:337: in replace_multiple_types
    return process_parts(input_str)
.../code_generation/doc_utils/utils.py:324: in process_parts
    replacement = find_symbol(codebase=codebase, symbol_name=part, resolved_types=resolved_types, parent_class=parent_class, parent_symbol=parent_symbol, types_cache=types_cache)
.../code_generation/doc_utils/utils.py:224: in find_symbol
    cls_obj = safe_get_class(codebase, symbol_name)
.../code_generation/doc_utils/utils.py:188: in safe_get_class
    symbols = codebase.get_symbols(class_name)
.../sdk/core/codebase.py:599: in get_symbols
    return sort_editables(x for x in self.symbols if x.name == symbol_name)
.../sdk/core/codebase.py:325: in symbols
    return self._symbols()
.../sdk/core/codebase.py:217: in _symbols
    matches: list[Symbol] = self.G.get_nodes(NodeType.SYMBOL)
.../sdk/codebase/codebase_graph.py:521: in get_nodes
    return [self.get_node(node_id) for node_id in self._graph.filter_nodes(lambda node: node.node_type == node_type)]
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

node = PyFunction(name='_resolved_types', filepath='.../core/expressions/placeholder_type.py', return_type=PyGene...ilepath='.../core/expressions/placeholder_type.py'), type_parameters=None, is_magic=False, is_private=True)

>   return [self.get_node(node_id) for node_id in self._graph.filter_nodes(lambda node: node.node_type == node_type)]
E   Failed: Timeout >120.0s

.../sdk/codebase/codebase_graph.py:521: Failed

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@jayhack jayhack merged commit 531932f into develop Jan 29, 2025
6 of 8 checks passed
@jayhack jayhack deleted the jay/docs-hotfix-1 branch January 29, 2025 23:34
jayhack added a commit that referenced this pull request Feb 9, 2025
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

Co-authored-by: codegen-bot <team+codegenbot@codegen.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants