Experiment: Override __class__ for Builtin types to shadow isinstance
#347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardJXLi
requested review from
christinewangcw
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files |
bagel897
approved these changes
Feb 6, 2025
EdwardJXLi
changed the title
__class__ for List and Dict types to shadow isinstance__class__ for Builtin types to shadow isinstance
jayhack
pushed a commit
that referenced
this pull request
Feb 9, 2025
…nce` (#347) This allows us to do `isinstance(symbol, list)` instead of `isinstance(symbol, codegen.sdk.core.List)` This applies to changes to: - List - Dict - Tuple - String - Number - Boolean
Contributor
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
tkfoss
pushed a commit
that referenced
this pull request
Feb 10, 2025
…nce` (#347) This allows us to do `isinstance(symbol, list)` instead of `isinstance(symbol, codegen.sdk.core.List)` This applies to changes to: - List - Dict - Tuple - String - Number - Boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to do
isinstance(symbol, list)instead ofisinstance(symbol, codegen.sdk.core.List)This applies to changes to: