CG-10899: file.add_import
#673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
bagel897
suggested changes
Feb 26, 2025
Contributor
bagel897
left a comment
bagel897
left a comment
There was a problem hiding this comment.
Some code seems to be copied from other PRs?
| @writer(commit=False) | ||
| def add_import_from_import_string(self, import_string: str) -> None: | ||
| """Adds import to the file from a string representation of an import statement. | ||
| def add_import(self, imp: Symbol | str, *, alias: str | None = None, import_type: ImportType = ImportType.UNKNOWN, is_type_import: bool = False) -> Import | None: |
Contributor
There was a problem hiding this comment.
Can we add typing overloads to make sure the user doesn't pass the other parameters if imp is of type str
| if any(import_string.strip() in imp.source for imp in self.imports): | ||
| return | ||
| # Handle Symbol imports | ||
| if isinstance(imp, str): |
Contributor
There was a problem hiding this comment.
Can we change the behavior to
- Convert import symbol to string (if it's a symbol)
- Insert the string with the same logic as the previous implementation?
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file.add_import_from_stringandfile.add_symbol_importhas now been consolidated into one methodfile.importwhich takes inSymbol | streither the string import or the Symbol that needs to be imported and will handle the logic