feat: adding keyboard navigation to Tabs component for accessibility … #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbourdon13
pushed a commit
to sbourdon13/react-dsfr
that referenced
this pull request
Aug 11, 2023
|
@garronej any thought to migrate to unstyled radix tabs https://www.radix-ui.com/primitives/docs/components/tabs ? instead of implementing manual a11y |
|
Thank you for this! So sorry I didn't merge it earlyer! |
We can't introduce any thrird party dependency to the core components. This project is a compatibility layer for https://github.com/GouvernementFR/dsfr |
|
hello, @garronej can you trigger a new release so I can enjoy this patch ? :) thx |
|
Sure sorry |
garronej
added a commit
that referenced
this pull request
Aug 24, 2023
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
A small addition to the Tab component in order to activate keyboard navigation to fit accessibility requirements.
I applied a similar logic from this file : https://github.com/GouvernementFR/dsfr/blob/main/src/component/tab/script/tab/tabs-group.js
Hope this will meet the standards