Skip to content

feat: Choose Hx level for Card title ref #160 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

feat: Choose Hx level for Card title ref #160 #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export type CardProps = {
id?: string;
className?: string;
title: ReactNode;
titleAs?: `h${2 | 3 | 4 | 5 | 6}`;
desc?: ReactNode;
imageUrl?: string;
imageAlt?: string;
Expand Down Expand Up @@ -81,6 +82,7 @@ export const Card = memo(
id: props_id,
className,
title,
titleAs: HtmlTitleTag = "h3",
linkProps,
desc,
imageUrl,
Expand Down Expand Up @@ -146,7 +148,7 @@ export const Card = memo(
>
<div className={cx(fr.cx("fr-card__body"), classes.body)}>
<div className={cx(fr.cx("fr-card__content"), classes.content)}>
<h3 className={cx(fr.cx("fr-card__title"), classes.title)}>
<HtmlTitleTag className={cx(fr.cx("fr-card__title"), classes.title)}>
{linkProps !== undefined ? (
<Link
{...linkProps}
Expand All @@ -157,7 +159,7 @@ export const Card = memo(
) : (
title
)}
</h3>
</HtmlTitleTag>
{desc !== undefined && (
<p className={cx(fr.cx("fr-card__desc"), classes.desc)}>{desc}</p>
)}
Expand Down
12 changes: 10 additions & 2 deletions stories/Card.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ const { meta, getStory } = getStoryFactory({
- [See source code](https://github.com/codegouvfr/react-dsfr/blob/main/src/Card.tsx)`,
"argTypes": {
"title": { "description": `Required.` },
titleAs: {
"description": `Heading level`,
"options": (() => {
const headings = ["h2", "h3", "h4", "h5", "h6"] as const;
assert<Equals<typeof headings[number] | undefined, CardProps["titleAs"]>>();
return headings;
})(),
"control": { "type": "radio" }
},
"desc": { "description": `` },
linkProps: {
"description": `Required only if enlargeLink is true. The Card Link props.`
Expand All @@ -30,9 +39,7 @@ const { meta, getStory } = getStoryFactory({
"description": "Card title text sizing",
"options": (() => {
const sizes = ["small", "medium", "large"] as const;

assert<Equals<typeof sizes[number] | undefined, CardProps["size"]>>();

return sizes;
})(),
"control": { "type": "radio" }
Expand All @@ -49,6 +56,7 @@ export default meta;
const defaultProps = {
"enlargeLink": true as const,
"title": "Intitulé de la carte (sur lequel se trouve le lien)",
"titleAs": "h3" as const,
"linkProps": {
"href": "#"
},
Expand Down