Skip to content

fix wrong type on target / currentTarget on SelectNext #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix wrong type on target / currentTarget on SelectNext #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/SelectNext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,24 @@ export type SelectProps<Options extends SelectProps.Option[]> = {
value?: Options[number]["value"];
onChange?: (
e: Omit<ChangeEvent<HTMLSelectElement>, "target" | "currentTarget"> & {
target: Omit<ChangeEvent<HTMLSelectElement>, "value"> & {
target: Omit<EventTarget & HTMLSelectElement, "value" | "selectedOptions"> & {
value: Options[number]["value"];
selectedOptions: HTMLCollectionOf<
Omit<HTMLOptionElement, "value"> & {
value: Options[number]["value"];
}
>;
};
currentTarget: Omit<ChangeEvent<HTMLSelectElement>, "value"> & {
currentTarget: Omit<
EventTarget & HTMLSelectElement,
"value" | "selectedOptions"
> & {
value: Options[number]["value"];
selectedOptions: HTMLCollectionOf<
Omit<HTMLOptionElement, "value"> & {
value: Options[number]["value"];
}
>;
};
}
) => void;
Expand Down
34 changes: 34 additions & 0 deletions test/types/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,3 +262,37 @@ import { assert, type Equals } from "tsafe";
}}
/>;
}

{
const dogOrCatOptions = [
{
value: "dog",
label: "Dog"
},
{
value: "cat",
label: "Cat"
}
] as const;

type DogOrCat = typeof dogOrCatOptions[number]["value"];
type SelectTarget = Omit<EventTarget & HTMLSelectElement, "value" | "selectedOptions"> & {
value: DogOrCat;
selectedOptions: HTMLCollectionOf<Omit<HTMLOptionElement, "value"> & { value: DogOrCat }>;
};
<Select
label="Dog or cat person?"
options={[...dogOrCatOptions]}
placeholder="Select an option"
nativeSelectProps={{
"onChange": event => {
assert<Equals<typeof event["currentTarget"], SelectTarget>>();
assert<Equals<typeof event["target"], SelectTarget>>();
const selectedValues = Array.from(event.target.selectedOptions).map(
option => option.value
);
assert<Equals<typeof selectedValues, DogOrCat[]>>;
}
}}
/>;
}