Skip to content

Conversation

@lsagetlethias
Copy link
Collaborator

@lsagetlethias lsagetlethias commented Sep 18, 2023

@lsagetlethias lsagetlethias marked this pull request as ready for review September 20, 2023 16:25
Copy link
Collaborator

@garronej garronej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few details.
Looks very good to me otherwise.

Thanks a lot for your work

@garronej
Copy link
Collaborator

Thanks a lot for the changes. I'll merge later today

@lsagetlethias
Copy link
Collaborator Author

Thanks a lot for the changes. I'll merge later today

Thanks! Also, I tagged you as reviewer on the documentation changes on GitBook

@garronej garronej force-pushed the feature/nonce-trusted-types-csp branch from dc341f5 to 7b0cb34 Compare September 29, 2023 12:17
@garronej
Copy link
Collaborator

garronej commented Sep 29, 2023

Okay, there were a few things to tweak:

  • `${undefined}` === "undefined" (and not "").
  • Internal functions should have all parameters set as required. This ensures we don't overlook anything and apply defaults only once, universally. Only external API should have optional params.
  • The tools directory is intended for self-contained utilities that solve generic problems. Not a misc dir.

Other than that, everything looks good. Thank you again for your diligent work.

@garronej garronej merged commit 48b6405 into main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants