Skip to content

Conversation

@sbourdon13
Copy link
Contributor

  • Badge can be a span or a p (default p). Same logic as the Summary component.
  • Update Badge default story
  • Create Header story with beta badge

Note: it works locally on storybook, but I'm not sure how to test on vite or next app for example. I launched the command yarn start-vite but it didn't create a local dev server, so I don't know what I'm supposed to do.

Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
@garronej
Copy link
Collaborator

garronej commented Oct 15, 2023

Thanks a lot!

Note: it works locally on storybook, but I'm not sure how to test on vite or next app for example. I launched the command yarn start-vite but it didn't create a local dev server, so I don't know what I'm supposed to do.

Hum maybe, the url is not prited in the console but the server is actually running... Or you are on windows and i'm using an explicit / path separator somewhere. Anywhere, there's no big deal!

I'm releasing a new version including you change.

@garronej garronej merged commit b9e8ae2 into codegouvfr:main Oct 15, 2023
@sbourdon13
Copy link
Contributor Author

Thanks! Yes I was working on Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants