Fixed incorrectly trying to raise an error #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Well, the build failed, but that's because a spec for another issue is nondeterministic: it sets up a future with a 1 second sleep inside a thread, then waits 2 seconds for that thread to terminate. Looks like this time it wasn't enough. I added another 0.5 seconds of sleep to better our chances of the thread terminating in time. |
Contributor
|
Looks awesome, thanks! |
josepjaume
added a commit
that referenced
this pull request
Feb 18, 2014
Fixed incorrectly trying to raise an error
Contributor
Author
|
Can you please release a new version with this fix? I'd love to get rid of the monkey patch I'm using for this right now :) |
Contributor
|
Of course! |
Contributor
|
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
Futureclass is a subclass ofDelegator, it tries to delegate everything. Evenraise! Thus, we need to explicitly callKernel.raise, otherwise we get aSystemStackError. The specs were incorrect as well, because they did not explicitly check for the error type and message, only expecting an::Exceptionto be raised.