Add PhoneNumber (contact) and refactor ValueObject trait#79
Merged
Conversation
added 5 commits
April 17, 2026 21:10
- Refactor ValueObject trait: rename Raw to Input, add Output type - Add EmailAddressInput/Output and CountryCodeInput/Output type aliases - Add EmailAddress::domain() and EmailAddress::local_part() accessors - Add PhoneNumber composite value object (CountryCode + local number → E.164) Closes #2
vhrcgcom
added a commit
that referenced
this pull request
Apr 21, 2026
Add PhoneNumber (contact) and refactor ValueObject trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
PhoneNumbercomposite value object — constructed fromCountryCode+ local number, stored andreturned as canonical E.164 (e.g.
+420123456789). Includes ITU calling code lookup for all 249 ISO3166-1 countries.
Also refactors
ValueObjecttrait to support composites:Rawsplit intoInput(whatnew()accepts) and
Output(whatvalue()returns). Simple types use identical type aliases; composites candiffer.
Closes #2
Type of change
Checklist
cargo fmt— code is formattedcargo clippy --features full,serde -- -Dclippy::all— no warningscargo test --features full,serde— all tests pass# Exampleblock