Merged
Conversation
7 value objects: Slug, Ean13, Ean8, Isbn13, Isbn10, Issn, Vin. EAN weight scheme uses length-aware formula (weight = 3 if even distance from right, 1 if odd) — this correctly handles both EAN-8 and EAN-13 without a separate implementation. Closes #12, #15, #16, #17, #18, #19, #20 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
codegresscom
approved these changes
Apr 20, 2026
This was
linked to
issues
Apr 20, 2026
Closed
Closed
Closed
Closed
Closed
Closed
vhrcgcom
pushed a commit
that referenced
this pull request
Apr 21, 2026
Add identifiers module (v0.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the full
identifiersmodule (v0.4.0) — 7 value objects with checksum validation.Slug[a-z0-9-], no leading/trailing/consecutive hyphensEan13Ean8Isbn13Isbn10IssnXXXX-XXXXVinNote on EAN checksum: EAN-8 and EAN-13 share the same GS1 right-to-left algorithm; the weight depends on distance from the right edge (
(n-i) % 2), so the starting weight from the left differs for even-length (EAN-8) and odd-length (EAN-13) codes.Closes #12
Closes #15
Closes #16
Closes #17
Closes #18
Closes #19
Closes #20
Type of change
Checklist
cargo fmt— code is formattedcargo clippy --features full,serde -- -Dclippy::all— no warningscargo test --features full,serde— all tests pass (165/165)# Exampleblock