Make it possible to use mouse for emulating eye tracking without installing tobii_research module #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is to be used in the cases where eye-tracker hardware (or eye-tracker emulation) returns position in pixels, rather than normalized position in the 0.0..1.0 that needs to be rescaled.
Now tobii_research [1][2] module does not need to be installed to be able to use mouse emulation. [1]: https://developer.tobiipro.com/python.html [2]: https://pypi.org/project/tobii-research/ This change removes 'import tobii_research as tr' from checkPythonEnvironment() method, and adjusts checkEyeTracker() and getEyeTrackerName() to work correctly even if tobii_research is not installed. Not tested yet. The problem with requiring tobii_research is that it requires specific Python version to be able to be installed: 3.8 or 3.10 [3][4][5] [3]: https://www.tobii.com/products/software/applications-and-developer-kits/tobii-pro-sdk [4]: https://developer.tobiipro.com/tobiiprosdk/platform-and-language.html [5]: https://codegrits.github.io/CodeGRITS/usage-guide/#python-environment
Member
|
Hi, thanks so much for your development and PR! I'm currently quite busy with a paper deadline this week. After that, I will review the PR and integrate it soon. |
This should fix the sporadic RuntimeExceptionWithAttachments exception in CodeGRITS plugin that happens on some projects when running eye tracker. com.intellij.openapi.diagnostic.RuntimeExceptionWithAttachments: Read access is allowed from inside read-action only (see Application.runReadAction()); If you access or modify model on EDT consider wrapping your code in WriteIntentReadAction ; see https://jb.gg/ij-platform-threading for details [...] at trackers.EyeTracker.getASTStructureElement(EyeTracker.java:450) at trackers.EyeTracker.lambda$processRawData$1(EyeTracker.java:306) This fix is based on the https://stackoverflow.com/q/76809649 and the discussion in issue codegrits#17 .
Contributor
Author
|
I should re-do this pull request using a separate branch to avoid introducing unrelated commits. I have forgot how pull requests in GitHub work, namely that they automatically update to most recent version of the branch... |
Contributor
Author
|
Replaced by PR #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how
AvailibilityChecker.checkPythonEnvironment()was set up, thetobii_researchmodule had to be installed in the selected Python environment even when one wanted to use Mouse emulation.Installing
tobii_researchis more difficult than installingpyautoguibecausetobii_researchrequires specific Python version, namely Python 3.10 (or Python 3.8, but with more work). Switching to non-default version of Python is more work.I have tested that mouse emulation work with these changes, but I was not able to check if tracking with Tobii still works.