Add synchronously entries from resource collections that do no support concurrent access #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexus-io 2.7 adds support for resource collection that does not allow concurrent access to it's entries. Add flag to ArchiveEntry so archiver implementations could know that they should add entries form such collections synchronously.
plamentotev
changed the title
plamentotev
changed the title
Member
Author
There was a problem hiding this comment.
Manifests are not added in parallel anyway but just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #10
This is somewhat simple approach. It adds entries synchronously while it could add them in parallel as long as it does not add them in parallel with entries from the same resource collection.
Alternative approach could be for example to have
Executorthat allows only one entry from a given non-concurrent collection to be added. Maybe it could lead to better performance but I would rather prefer the simpler approach.