Remove obsolete TODO comments from BuildContext interface #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes two obsolete TODO comments from the
BuildContext
interface that have been in the codebase for many years without being addressed.Changes
Removed the following TODO comments from
src/main/java/org/codehaus/plexus/build/BuildContext.java
:Line 22:
// TODO should it be BuildWorkspace or something like that?
Line 33:
// TODO should we add File getBasedir()?
Rationale
As noted in issue #XX: "Code is not an issue tracker." These TODO comments represented questions about potential changes that were never acted upon. After years of stable API usage, they serve no purpose and only clutter the code.
If these changes were truly important, they would have been addressed long ago or converted to proper issues. Their presence as inline comments suggests they are not critical for the project.
Verification
mvn clean compile
Fixes #XX
Original prompt
Fixes #41
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.