Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 13, 2025

Summary

This PR removes two obsolete TODO comments from the BuildContext interface that have been in the codebase for many years without being addressed.

Changes

Removed the following TODO comments from src/main/java/org/codehaus/plexus/build/BuildContext.java:

  1. Line 22: // TODO should it be BuildWorkspace or something like that?

    • This was questioning whether the interface should be renamed. Given that the API has been stable and widely used for many years, this question is no longer relevant.
  2. Line 33: // TODO should we add File getBasedir()?

    • This was questioning whether to add a new method to the interface. Since this was never implemented despite being there for years, it's clear the method is not needed.

Rationale

As noted in issue #XX: "Code is not an issue tracker." These TODO comments represented questions about potential changes that were never acted upon. After years of stable API usage, they serve no purpose and only clutter the code.

If these changes were truly important, they would have been addressed long ago or converted to proper issues. Their presence as inline comments suggests they are not critical for the project.

Verification

  • ✅ Project builds successfully with mvn clean compile
  • ✅ No functional changes to the API
  • ✅ No TODO comments remain in Java source files

Fixes #XX

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove TODOs</issue_title>
<issue_description>There are some TODOs in the code, given that these never are addressed until now they are maybe not important anymore this should be removed or transferred into a dedicated issue.

Code is not an issue tracker...</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #41


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: slachiewicz <6705942+slachiewicz@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Remove TODOs from the codebase Remove obsolete TODO comments from BuildContext interface Oct 13, 2025
@Copilot Copilot AI requested a review from slachiewicz October 13, 2025 20:48
Copilot finished work on behalf of slachiewicz October 13, 2025 20:48
@slachiewicz slachiewicz marked this pull request as ready for review October 13, 2025 21:17
@laeubi laeubi merged commit e1aba62 into master Oct 14, 2025
17 checks passed
@slachiewicz slachiewicz deleted the copilot/remove-todos-from-code branch October 14, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove TODOs

3 participants