Merged
Conversation
Highlights: - Set pointerEvents="none" on static chart canvas containers so Skia-drawn lines no longer intercept taps; buttons and pressables receive touches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets
pointerEventstononeon static chart canvas containers so Skia-drawn lines no longer intercept taps; buttons and pressables receive touches.Motivation and Context
In newer versions of Skia, components seem to be intercepting taps, causing issues with touchable elements (e.g.,
Pressable) not having their onPress's register.How Has This Been Tested?
Manually on the porfoli app.
Types of changes
Checklist: