Dev: using `filter_*` functions instead direct access to global variables

[WinterSilence]

Example:

$_GET['foo'] = 1;
var_export($_GET); // ['foo' => 1]
var_export(filter_input_array(INPUT_GET)); // []

As you can see filter_input_array() return initial data, it's better use in CI because users (or vendor packages) can change globals before calling CI methods.

If there are no objections, then I will replace direct access to global variables everywhere. I will write sniff to fix this problem in future too.

[kenjis]

As you can see filter_input_array() return initial data, it's better use in CI because users (or vendor packages) can change globals before calling CI methods.

filter_input_array(INPUT_GET)) returns the GET data that only in the incomming request?
If so, the change you suggrest is too restrictive for the current design of CI4,
and may break the exsisting test code.

The current test/product code is heavily depends on the suprer global variables.

[WinterSilence]

@kenjis please see manual, it's only example to display: filter_input_array() returning initial data without changes.

[kenjis]

Sorry, I know INPUT_GET is example.

If we use filter_input_array(), we can't change the data., right?
If we can't change the data, we can't write test code.

[WinterSilence]

@kenjis https://phpunit.readthedocs.io/en/9.5/fixtures.html#global-state

[kenjis]

@WinterSilence What is your point?

[WinterSilence]

@ kenjis one test = one request, change globals in test is bad practice

[kenjis]

@WinterSilence CI4 has a lot of (test/production) code that depends on super global variables.
If we add this change, will all our existing tests pass?

[WinterSilence]

@kenjis i don't check all test, but if they are written correctly, then it must be work fine.

[kenjis]

I confirmed the behavior.

<?php
namespace App\Controllers;

class Home extends BaseController
{
    public function index()
    {
        $_GET['foo'] = 1;
        d($_GET); // ['foo' => 1]
        d(filter_input_array(INPUT_GET)); // []
    }

}

[kenjis]

@WinterSilence
Will this test pass?
https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/system/HTTP/IncomingRequestTest.php#L48-L54

[WinterSilence]

@kenjis

but if they are written correctly, then it must be work fine.

it's not correct tests.

You can keep "pure" request data if any user or vendor library can change they. I didn't say that the right decisions are easy. And I didn't say that it's enough to replace global variables with a call filter_*().

[kenjis]

@WinterSilence

it's not correct tests.

How do you fix the test (and product code)?
https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/system/HTTP/IncomingRequestTest.php#L48-L54