chore: migrate from deptrac to structarmed#10198
Conversation
|
Ready for review/merge 👍 |
|
I've bumped to structarmed 0.5.2 with parallel run by default so it faster run 👍 Before After |
|
I've applied some hotfixes with latest structarmed 0.5.4, I think this is ready for review/merge 👍 |
8e5532f to
aeba5b2
Compare
|
I've rebased latest develop, ready to review/merge 👍 |
deptrac to structarmed
paulbalandan
left a comment
There was a problem hiding this comment.
I think I like it better now the config is in PHP instead of YAML. Few notes:
michalsn
left a comment
There was a problem hiding this comment.
It looks like this implementation is almost twice as fast as deptrac. Even if we're talking about a few seconds rather than tens of seconds, it seems like a step in the right direction, since the solution is written entirely in PHP.
paulbalandan
left a comment
There was a problem hiding this comment.
Looks good. Please squash on merge.
c4f79a0 to
dadab91
Compare
|
Thank you @paulbalandan @michalsn for the review. I've squash it and will merge it 👍 |
Description
@michalsn @MGatner this PR bump stuctarmed to 0.5.0 and migrate deptrac to structarmed for use of namespace regex pattern and ruleset definition.
per release note: https://github.com/boundwize/structarmed/releases/tag/0.5.0
Checklist: