Skip to content

chore: migrate from deptrac to structarmed#10198

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:migrate-deptrac-to-structarmed
May 15, 2026
Merged

chore: migrate from deptrac to structarmed#10198
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:migrate-deptrac-to-structarmed

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Description

@michalsn @MGatner this PR bump stuctarmed to 0.5.0 and migrate deptrac to structarmed for use of namespace regex pattern and ruleset definition.

per release note: https://github.com/boundwize/structarmed/releases/tag/0.5.0

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@github-actions github-actions Bot added the github_actions Pull requests that update Github_actions code label May 13, 2026
@samsonasik samsonasik changed the title Migrate deptrac to structarmed chore: Migrate deptrac to structarmed May 13, 2026
@samsonasik
Copy link
Copy Markdown
Member Author

Ready for review/merge 👍

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented May 14, 2026

I've bumped to structarmed 0.5.2 with parallel run by default so it faster run 👍

Before

StructArmed — Architecture Enforcement
==========================================

✅  No violations found. (20.62s)

After

StructArmed — Architecture Enforcement
==========================================

✅  No violations found. (7.36s)

@samsonasik samsonasik requested a review from kenjis May 14, 2026 13:02
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented May 14, 2026

I've applied some hotfixes with latest structarmed 0.5.4, I think this is ready for review/merge 👍

@samsonasik samsonasik force-pushed the migrate-deptrac-to-structarmed branch from 8e5532f to aeba5b2 Compare May 14, 2026 19:18
@samsonasik
Copy link
Copy Markdown
Member Author

I've rebased latest develop, ready to review/merge 👍

@paulbalandan paulbalandan changed the title chore: Migrate deptrac to structarmed chore: migrate from deptrac to structarmed May 14, 2026
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like it better now the config is in PHP instead of YAML. Few notes:

Comment thread structarmed.php Outdated
Comment thread structarmed.php
Comment thread structarmed.php Outdated
Comment thread structarmed.php
@samsonasik samsonasik requested a review from paulbalandan May 14, 2026 20:09
Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this implementation is almost twice as fast as deptrac. Even if we're talking about a few seconds rather than tens of seconds, it seems like a step in the right direction, since the solution is written entirely in PHP.

Comment thread structarmed.php
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please squash on merge.

@samsonasik samsonasik force-pushed the migrate-deptrac-to-structarmed branch from c4f79a0 to dadab91 Compare May 15, 2026 06:48
@samsonasik
Copy link
Copy Markdown
Member Author

Thank you @paulbalandan @michalsn for the review. I've squash it and will merge it 👍

@samsonasik samsonasik merged commit ea47e73 into codeigniter4:develop May 15, 2026
49 checks passed
@samsonasik samsonasik deleted the migrate-deptrac-to-structarmed branch May 15, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants