Skip to content

Ignore callbacks in routes list#1859

Merged
lonnieezell merged 1 commit intocodeigniter4:developfrom
MGatner:cli-routes-strings-filter
Mar 23, 2019
Merged

Ignore callbacks in routes list#1859
lonnieezell merged 1 commit intocodeigniter4:developfrom
MGatner:cli-routes-strings-filter

Conversation

@MGatner
Copy link
Copy Markdown
Member

@MGatner MGatner commented Mar 22, 2019

Description
The CLI command Routes iterates routes from system & app to display them as a table, but ends up trying to display callbacks. This change ignores any $to destinations that aren't strings.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

The CLI command Routes iterates routes from system & app to display them as a table, but ends up trying to display callbacks. This change ignores any `$to` destinations that aren't strings.
@lonnieezell lonnieezell merged commit 7e1c666 into codeigniter4:develop Mar 23, 2019
@MGatner MGatner deleted the cli-routes-strings-filter branch March 23, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants