Skip to content

Module wise Typos changes#1863

Merged
lonnieezell merged 13 commits intocodeigniter4:developfrom
atishhamte:typos
Mar 26, 2019
Merged

Module wise Typos changes#1863
lonnieezell merged 13 commits intocodeigniter4:developfrom
atishhamte:typos

Conversation

@atishhamte
Copy link
Contributor

@atishhamte atishhamte commented Mar 23, 2019

Typos changes module wise

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@atishhamte
Copy link
Contributor Author

@jim-parry & @lonnieezell, I didn't make any changes in the PHPUnit configs. Then too getting this error.

PHP Fatal error:  Uncaught SebastianBergmann\Timer\RuntimeException: Cannot determine time at which the request started in /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/php-timer/src/Timer.php:85
Stack trace:
#0 /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/php-timer/src/Timer.php(98): SebastianBergmann\Timer\Timer::timeSinceStartOfRequest()
#1 /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php(410): SebastianBergmann\Timer\Timer::resourceUsage()
#2 /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php(183): PHPUnit\TextUI\ResultPrinter->printHeader()
#3 /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(652): PHPUnit\TextUI\ResultPrinter->printResult(Object(PHPUnit\Framework\TestResult))
#4 /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/Command.php(206): PHPUnit\TextUI\TestRunner->doRun(Object(PHPUnit\Framework\TestSuite), Array, true)
# in /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/php-timer/src/Timer.php on line 85
Fatal error: Uncaught SebastianBergmann\Timer\RuntimeException: Cannot determine time at which the request started in /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/php-timer/src/Timer.php on line 85
SebastianBergmann\Timer\RuntimeException: Cannot determine time at which the request started in /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/php-timer/src/Timer.php on line 85
Call Stack:
    0.0001     424032   1. {main}() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:0
    0.0043     937984   2. PHPUnit\TextUI\Command::main() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:61
    0.0043     938096   3. PHPUnit\TextUI\Command->run() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/Command.php:162
    0.5041   20627472   4. PHPUnit\TextUI\TestRunner->doRun() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/Command.php:206
  250.7060  207901256   5. PHPUnit\TextUI\ResultPrinter->printResult() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:652
  250.7060  207901256   6. PHPUnit\TextUI\ResultPrinter->printHeader() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php:183
  250.7060  207901256   7. SebastianBergmann\Timer\Timer::resourceUsage() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php:410
  250.7060  207901256   8. SebastianBergmann\Timer\Timer::timeSinceStartOfRequest() /home/travis/build/codeigniter4/CodeIgniter4/vendor/phpunit/php-timer/src/Timer.php:98

Please guide me, where I have made the changes, as everything is working fine in the local environment.

@jim-parry
Copy link
Contributor

I haven't seen this error before!
Googling led to sebastianbergmann/phpunit#3026
That suggests enabling backup & restore of $GLOBALS, but I don't see that you have changed that.
The only thing I can think of is to break the PR into smaller ones, eg one per commt in the history above.

@jim-parry
Copy link
Contributor

The return type of color() fixed the travos-ci break? go figure!

@atishhamte
Copy link
Contributor Author

Nope. The getUserInfo() method of URI return type is given string in coment block. I have reverted the same.
But we need to figure it out the actual return types of methods.
There are many methods in Database module have incorrect return type documented.

@atishhamte
Copy link
Contributor Author

Typos changes completed. No more commits in this PR.

@atishhamte
Copy link
Contributor Author

Any update on this PR. Is any change required?

@lonnieezell
Copy link
Member

Looks fine to me. Merging.

@lonnieezell lonnieezell merged commit 5521894 into codeigniter4:develop Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants