Skip to content

Added app/Common.php#2105

Closed
jason-napolitano wants to merge 1 commit intocodeigniter4:developfrom
jason-napolitano:develop
Closed

Added app/Common.php#2105
jason-napolitano wants to merge 1 commit intocodeigniter4:developfrom
jason-napolitano:develop

Conversation

@jason-napolitano
Copy link
Copy Markdown
Contributor

A commit that will hopefully help with this topic: #2101

Signed-off-by: jason-napolitano jnapolitanoit@gmail.com

Each pull request should address a single issue, and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345
  • Unsolicited PRs will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

A commit that will hopefully help with this topic: #2101

Signed-off-by: jason-napolitano <jnapolitanoit@gmail.com>
@jbotka
Copy link
Copy Markdown
Contributor

jbotka commented Jul 26, 2019

Do you need help with this?

@jim-parry
Copy link
Copy Markdown
Contributor

commits need to be gpg-signed, instead of having a PR "signed off", thanks

@jim-parry jim-parry closed this Jul 26, 2019
@jason-napolitano
Copy link
Copy Markdown
Contributor Author

Yeah @jim-parry, my PHPStorm IDE had an issue with GPG signing (apparently it is still an issue with PHPStorm's Terminal not catching the correct flag upon push) Sorry about that. I'll update my IDE settings and submit a new PR later today.

Thanks.

@jim-parry
Copy link
Copy Markdown
Contributor

I do my GPG-signing from the command line, rather than fight an IDE.

@MGatner
Copy link
Copy Markdown
Member

MGatner commented Jul 27, 2019

@jason-napolitano I work occasionally in a setting where I cannot setup GPG, so if I have to commit I paste the code right into GitHub which will automatically verify. It isn’t ideal but handy to have as a backup.

@jason-napolitano jason-napolitano mentioned this pull request Jul 28, 2019
5 tasks
@jason-napolitano
Copy link
Copy Markdown
Contributor Author

@MGatner that is what I ended up doing for #2110 since it is a simple one. I'll get my ducks in order for any potential future PR's so I can rest assured that everything is setup right.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants