Added app/Common.php#2105
Closed
jason-napolitano wants to merge 1 commit intocodeigniter4:developfrom
jason-napolitano:develop
Closed
Added app/Common.php#2105jason-napolitano wants to merge 1 commit intocodeigniter4:developfrom jason-napolitano:develop
jason-napolitano wants to merge 1 commit intocodeigniter4:developfrom
jason-napolitano:develop
Conversation
A commit that will hopefully help with this topic: #2101 Signed-off-by: jason-napolitano <jnapolitanoit@gmail.com>
Contributor
|
Do you need help with this? |
Contributor
|
commits need to be gpg-signed, instead of having a PR "signed off", thanks |
Contributor
Author
|
Yeah @jim-parry, my PHPStorm IDE had an issue with GPG signing (apparently it is still an issue with PHPStorm's Terminal not catching the correct flag upon push) Sorry about that. I'll update my IDE settings and submit a new PR later today. Thanks. |
Contributor
|
I do my GPG-signing from the command line, rather than fight an IDE. |
Member
|
@jason-napolitano I work occasionally in a setting where I cannot setup GPG, so if I have to commit I paste the code right into GitHub which will automatically verify. It isn’t ideal but handy to have as a backup. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A commit that will hopefully help with this topic: #2101
Signed-off-by: jason-napolitano jnapolitanoit@gmail.com
Each pull request should address a single issue, and have a meaningful title.
Description
Explain what you have changed, and why.
Checklist:
---------Remove from here down in your description----------
Notes
(e.g. fixes 12345
to the develop branch of the project repository