Skip to content

Optimize Model#3754

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:model-optimize
Oct 15, 2020
Merged

Optimize Model#3754
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:model-optimize

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

@paulbalandan paulbalandan commented Oct 10, 2020

Description
Optimized Model.

  • Removes unneeded variables.
  • Uses truthy checks and null coalescing operators where possible
  • Make setter methods return $this for easy method chaining.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner reviewed Oct 13, 2020
View reviewed changes
Comment thread system/Model.php
Comment thread system/Model.php
@paulbalandan
Copy link
Copy Markdown
Member Author

paulbalandan commented Oct 15, 2020

composer remove --dev phpstan/phpstan is failing

@samsonasik
Copy link
Copy Markdown
Member

samsonasik commented Oct 15, 2020

@paulbalandan that fixed at #3772 , I will merge that first.

@samsonasik
Copy link
Copy Markdown
Member

samsonasik commented Oct 15, 2020

@paulbalandan please rebase, should be ok now.

@paulbalandan paulbalandan merged commit 29beadf into codeigniter4:develop Oct 15, 2020
@paulbalandan paulbalandan deleted the model-optimize branch October 15, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner left review comments

@michalsn michalsn michalsn approved these changes

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulbalandan @samsonasik @michalsn @MGatner