Skip to content

Bug fix: ensure to use autoload = false in class_exists() in low-hanging fruit in Factories::locateClass() #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Oct 15, 2020
Merged

Bug fix: ensure to use autoload = false in class_exists() in low-hanging fruit in Factories::locateClass() #3772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7152cdb
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
samsonasik Oct 15, 2020
b263bac
use --update-with-dependencies on composer remove command
samsonasik Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test-phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ jobs:
- name: Install dependencies
run: |
composer install --no-progress --no-suggest --no-interaction --prefer-dist --optimize-autoloader
composer remove --dev phpstan/phpstan
composer remove --dev rector/rector
composer remove --dev codeigniter4/codeigniter4-standard
composer remove --dev squizlabs/php_codesniffer
composer remove --dev rector/rector --update-with-dependencies
composer remove --dev phpstan/phpstan --update-with-dependencies
composer remove --dev codeigniter4/codeigniter4-standard --update-with-dependencies
composer remove --dev squizlabs/php_codesniffer --update-with-dependencies
composer update
php -r 'file_put_contents("vendor/laminas/laminas-zendframework-bridge/src/autoload.php", "");'
env:
Expand Down
2 changes: 1 addition & 1 deletion system/Config/Factories.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ public static function __callStatic(string $component, array $arguments)
protected static function locateClass(array $config, string $name): ?string
{
// Check for low-hanging fruit
if (class_exists($name) && self::verifyPrefersApp($config, $name) && self::verifyInstanceOf($config, $name))
if (class_exists($name, false) && self::verifyPrefersApp($config, $name) && self::verifyInstanceOf($config, $name))
{
return $name;
}
Expand Down