Skip to content

Add BC Break Policy#3790

Merged
samsonasik merged 1 commit intocodeigniter4:developfrom
samsonasik:add-bc-break-policy
Oct 20, 2020
Merged

Add BC Break Policy#3790
samsonasik merged 1 commit intocodeigniter4:developfrom
samsonasik:add-bc-break-policy

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Checklist:

  • Securely signed commits

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some more verbose and different wording

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md
Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is badly needed. Though I doubt that people will read this before sending a PR, at least we'll have a place to send them to for an explanation.

@samsonasik samsonasik merged commit 13ff147 into codeigniter4:develop Oct 20, 2020
@samsonasik samsonasik deleted the add-bc-break-policy branch October 20, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants