Fix undefined property BaseConfig::$key#3808
Merged
samsonasik merged 1 commit intocodeigniter4:developfrom Oct 24, 2020
paulbalandan:undefined-baseconfig-prop
Merged
Fix undefined property BaseConfig::$key#3808samsonasik merged 1 commit intocodeigniter4:developfrom paulbalandan:undefined-baseconfig-prop
samsonasik merged 1 commit intocodeigniter4:developfrom
paulbalandan:undefined-baseconfig-prop
Conversation
samsonasik
approved these changes
Oct 24, 2020
MGatner
approved these changes
Oct 24, 2020
Member
|
Thank you @paulbalandan |
samsonasik
reviewed
Oct 24, 2020
| $this->initEnvValue($this->$property, $property, $prefix, $shortPrefix); | ||
|
|
||
| if ($shortPrefix === 'encryption' && $property === 'key') | ||
| if ($this instanceof Encryption && $property === 'key') |
Member
There was a problem hiding this comment.
actually, parent should not know about the child implementation, but probably that next refactor, like have abstract method that called and overridden in child.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before PHPStan v0.12.51, initialisation of
Config\Encryption's$keyproperty viaBaseConfigis not marked as error. This was due to, as the author states, PHPStan not really doing the check at all. However, this is now being marked as erroneous.See: phpstan/phpstan@3998
Checklist: