HTTP Phase 1

[MGatner]

Description

This is an attempt at a gentler approach to moving our HTTP layer towards PSR compliance. This includes a number of deprecations, which I will note in the User Guide and CHANGELOG once we've had some time to discuss this.

See https://github.com/codeigniter4/CodeIgniter4/projects/5

• Splits out non-PSR-7 HTTP class methods into traits
• Deprecates unnecessary or conflicting methods
• Reimplements framework to remove deprecated methods (partial)
• Adds MessageInterface to clarify child class requirements

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

A little hard to see sometimes with so many changes to those files, but in general I'm ok with this solution, I think. Nice job.

[MGatner]

A little hard to see sometimes with so many changes to those files

I'm trying to split things into logical commit chunks to make the review easier. I could see some merit in splitting this into a few different PRs: deprecations, trait splits, Response refactor. Let me know if you'd prefer that.

[lonnieezell]

I could see some merit in splitting this into a few different PRs: deprecations, trait splits, Response refactor. Let me know if you'd prefer that.

Nah. You're good as is.

[MGatner]

GitHub Actions appears to be bugging out. I think the tests are all passing but someone should rerun at a later time.

[paulbalandan]

I trust all is well for this big PSR-7 compliance.

Some notes below.

[samsonasik]

Documentation PSR compliance may need to be updated http://codeigniter.com/user_guide/intro/psr.html

[MGatner]

I trust all is well for this big PSR-7 compliance.

Documentation PSR compliance may need to be updated http://codeigniter.com/user_guide/intro/psr.html

Just to be clear, this is by no means PSR-7 compliant yet. The deprecations and interface updates will make space for a new layer of PSR-7-compliant classes but current conflicts prevent us from implementing those. Also, I don't see the framework itself using a compliant HTTP layer because there is currently too much built into the Message/Request/Response classes that breaks compliance. The short-term plan is to apply those requirements onto any PSR-7 set of classes to make them work with the framework, and so third-party packages could use the framework's intermediate layer instead of adding another one.

[paulbalandan]

Looks okay to me, just with very minor fixes.