Skip to content

Update spell on readme. #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paulbalandan merged 1 commit into from
Dec 21, 2020
Merged

Update spell on readme. #4009

paulbalandan merged 1 commit into from
Dec 21, 2020

Conversation

@totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Dec 21, 2020 •
edited
Loading

Description
Update spell

Checklist:

  • Securely signed commits

paulbalandan
paulbalandan requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve only the addition of the Oxford comma. For the other changes, please revert.

Also, your changes are not on spelling so update your commit message, please.

@paulbalandan paulbalandan merged commit 302b86f into codeigniter4:develop Dec 21, 2020
@totoprayogo1916 totoprayogo1916 deleted the update/grammar branch December 21, 2020 15:10
@totoprayogo1916 totoprayogo1916 mentioned this pull request Dec 22, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@totoprayogo1916 @paulbalandan