Update examples #4022
Merged
Update examples #4022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Dec 24, 2020
totoprayogo1916
force-pushed
the
use-short-tag
branch
from
0350adc to
6c3f740
Compare
Member
|
While you're here @totoprayogo1916 would you change the case on booleans? Style Guide specifies they should be "true" and "false". |
Contributor
Author
What does it mean? I just fixed the example on Userguide, and didn't change anything else. |
MGatner
reviewed
Dec 25, 2020
totoprayogo1916
force-pushed
the
use-short-tag
branch
from
6c3f740 to
19eb030
Compare
totoprayogo1916
force-pushed
the
use-short-tag
branch
3 times, most recently
from
3b10d14 to
b18516d
Compare
totoprayogo1916
force-pushed
the
use-short-tag
branch
from
b18516d to
1a0132e
Compare
paulbalandan
approved these changes
Dec 26, 2020
totoprayogo1916
force-pushed
the
use-short-tag
branch
from
1a0132e to
40efbe1
Compare
totoprayogo1916
force-pushed
the
use-short-tag
branch
from
40efbe1 to
9c8652e
Compare
MGatner
approved these changes
Dec 26, 2020
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Nice work. Thank you @totoprayogo1916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the echo samples
Checklist: