[Requirement] Move validate php version check to CodeIgniter class

[samsonasik]

By centralize check, no need to change in separate files between spark and public/index.php anymore.

Checklist:

• Securely signed commits

[MGatner]

1. This moves the check later in both entry points. Is there anything that would fail on lower PHP versions in between?
2. What does a dedicated class have to offer? We already track the framework version on CodeIgniter\CodeIgniter, seems like it might be a logical place to group this: const CI_VERSION = '4.1.1';

[samsonasik]

1. lower php version will be fail, eg in php 5.2, probably just use function and check very early (need require_once)
2. yes, that can be in CodeIgniter class, what do you prefer?

[MGatner]

I guess I'm not too worries about PHP < 7, as long as executed code will work up until the check in 7+. This will become more relevant as we drop versions moving forward, so for example if someone does not read the release notes and makes a point upgrade that breaks their app at least they will know why.

I would be in favor of consolidating this to CodeIgniter because of our framework version tracking there, but it's not a strong opinion. We can see what others think.

[samsonasik]

@MGatner I've moved the check to CodeIgniter class 077ca27

[samsonasik]

All green 🎉

[MGatner]

The version constraint looks good, thank you for moving it! I'm not sure what has happened with the explosion of use statement changes but I would prefer to see all that in a separate PR.

[mostafakhudair]

@MGatner CLI is accessible without php version check

[totoprayogo1916]

Is it possible, if this is added to Lang?

[samsonasik]

@totoprayogo1916 if you mean for multi language, I am not sure since it early executed.

[MGatner]

lang() is definitely not available yet. In general I'm okay with strictly internal messages being in English. I understand there are some internationalization efforts for PHP core but I think this is still pretty common?

[samsonasik]

@MGatner I create separate PR for rector notice #4430

[samsonasik]

rebased.

[MGatner]

Looks much better! Thanks for splitting that. What about @mostafakhudair's concern that CLI execution bypasses version check?

[samsonasik]

@mostafakhudair any step to reproduce for by pass via cli ? I can't reproduce via spark command.

[mostafakhudair]

@samsonasik @MGatner everything is working well now, I didn't know what was the problem.