[Rector] Apply Rector: RemoveDuplicatedArrayKeyRector#4978
Merged
samsonasik merged 5 commits intocodeigniter4:developfrom Aug 1, 2021
Merged
Conversation
samsonasik
commented
Jul 29, 2021
Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
paulbalandan
approved these changes
Jul 29, 2021
MGatner
requested changes
Jul 29, 2021
Member
MGatner
left a comment
There was a problem hiding this comment.
The array keys on the provider in CreditCardRulesTest.php should stay. These are used to name data sets during test failure. (e.g. "testValidCCNumber failed with data set 'not_numierc'") and make it easier to track down the actual failure - otherwise it enumerates all the data from the provider which can make for a messy output.
Member
Author
|
@MGatner when the key are same, only last that used, do you think that should be named indexed, eg: hsbc1, etc 'hsbc' => [
'hsbc',
$this->generateCardNum(56, 16),
true,
],
- 'hsbc' => [
+ 'hsbc1' => [
'hsbc',
$this->generateCardNum(57, 16), |
Member
|
Yes |
Member
Author
|
@MGatner implemented |
Member
Author
|
@MGatner I am merging it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated key in defined arrays with
RemoveDuplicatedArrayKeyRectorrector rule.Checklist: