Bump to php-cs-fixer v3.1#5045
Conversation
|
I may be blind, but should the |
MGatner
left a comment
There was a problem hiding this comment.
I would not have guessed class_definition, rather the opposite since I always thought of the "class" as a stand-in for the actual class name, so the parentheses were adjoining for construction. I like the consistency with Closure you pointed out though.
|
@sfadschm You're not wrong, it's a bit confusing. This will ultimate land at https://github.com/CodeIgniter/coding-standard which will be applied here, but the easiest way to see the effects of each rule (especially while we're getting set up) is to apply them to the framework directly. I'm sure Paul will bump the Composer version at the source repo when it is ready. See also #5038 |
|
Oh right. Just thought the fixer might complain in the checks, when its on 3.0 but some rules are from 3.1. |
Description
New fixers applied:
declare_parenthesesempty_loop_bodyclass_keyword_removetypes_spacesclass_definitionOnly fixer with effect is the new option of
class_definitionadding a space before the parenthesis of anonymous class instantiation to line it with PSR12 requirement that anonymous classes should follow and behave like closures.Checklist: