Skip to content

docs: fix views.rst#5413

Merged
paulbalandan merged 2 commits intocodeigniter4:developfrom
kenjis:fix-docs-views.rst
Dec 3, 2021
Merged

docs: fix views.rst#5413
paulbalandan merged 2 commits intocodeigniter4:developfrom
kenjis:fix-docs-views.rst

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Nov 30, 2021

Description

  • fix sample code
    • It is not good practice to output variables without escaping.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
docs: add esc() to views
4d8266d 
It is not good practice to show variables without escaping
@kenjis
docs: fix coding style
2fb74d0
@kenjis kenjis added the documentation Pull requests for documentation only label Nov 30, 2021
@paulbalandan paulbalandan merged commit b350d76 into codeigniter4:develop Dec 3, 2021
@kenjis kenjis deleted the fix-docs-views.rst branch December 3, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @paulbalandan