Skip to content

Conversation

@samsonasik
Copy link
Member

Rector 0.12.10 has new Option::PARALLEL to speed up process, It now require Psr4 to be applied in tests to avoid Class was not found notice, ref rectorphp/rector#6903

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Member Author

It works 🎉 Github uses 2 Core so its improvement is 2x faster.

Before: 5m5s, ref https://github.com/codeigniter4/CodeIgniter4/runs/4674999414?check_suite_focus=true#step:10:4

Screen Shot 2022-01-02 at 04 19 37

After: 2m36s, ref https://github.com/codeigniter4/CodeIgniter4/runs/4681175691?check_suite_focus=true#step:10:1

Screen Shot 2022-01-02 at 04 19 14

@samsonasik
Copy link
Member Author

All green 🎉

@samsonasik samsonasik merged commit bfa2262 into codeigniter4:develop Jan 2, 2022
@samsonasik samsonasik deleted the apply-parallel-rector branch January 2, 2022 11:13
@MGatner
Copy link
Member

MGatner commented Jan 2, 2022

@samsonasik This is amazing! Thanks for being on top of all the latest.

Would you apply any relevant changes to https://github.com/codeigniter4/devkit?

@samsonasik
Copy link
Member Author

@MGatner yes codeigniter4/devkit#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants