Skip to content

[Docs] Fix example php code in docs.#5721

Closed
sfadschm wants to merge 9 commits intocodeigniter4:developfrom
sfadschm:docs-fix-examples
Closed

[Docs] Fix example php code in docs.#5721
sfadschm wants to merge 9 commits intocodeigniter4:developfrom
sfadschm:docs-fix-examples

Conversation

@sfadschm
Copy link
Copy Markdown
Contributor

@sfadschm sfadschm commented Feb 22, 2022

This is the follow up of #5689.

It aims to make all php examples executable and apply our CS rules.

Status:

  • Convert non-php code.
  • Display opening tags (for PHP) and closing tags (for mixed HTML).
  • Remove occurences of . :.
  • Replace utf-8 characters (except the euro and pound signs).
  • Fix missing class definitions.
  • Fix remaining syntax errors.
  • Enable and run php-cs-fixer for user_guide_src\source.
  • Resolve merge conflicts.

Comment thread user_guide_src/source/incoming/incomingrequest.rst Outdated
@kenjis
Copy link
Copy Markdown
Member

kenjis commented Feb 22, 2022

@sfadschm
This PR is going to be very big.
Can you break it up into smaller PRs?

@sfadschm
Copy link
Copy Markdown
Contributor Author

@sfadschm This PR is going to be very big. Can you break it up into smaller PRs?

Yes, will do 😄

@sfadschm
Copy link
Copy Markdown
Contributor Author

I am splitting this up and will rebase the later ones when the first ones are merged.

@sfadschm sfadschm closed this Feb 22, 2022
@sfadschm sfadschm deleted the docs-fix-examples branch February 26, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants