Skip to content

[Docs-1] Convert non-php code.#5722

Merged
kenjis merged 14 commits intocodeigniter4:developfrom
sfadschm:docs-non-php-code
Feb 25, 2022
Merged

[Docs-1] Convert non-php code.#5722
kenjis merged 14 commits intocodeigniter4:developfrom
sfadschm:docs-non-php-code

Conversation

@sfadschm
Copy link
Copy Markdown
Contributor

@sfadschm sfadschm commented Feb 22, 2022 •
edited
Loading

This is the follow up of #5689.

[x] Convert non-php code in examples to valid php.

Some of these changes are not valid php syntax or go against the style guide. This will be fixed in a later step.

@sfadschm sfadschm mentioned this pull request Feb 22, 2022
Merged
@sfadschm sfadschm marked this pull request as ready for review February 22, 2022 17:05
@kenjis kenjis added the documentation Pull requests for documentation only label Feb 23, 2022
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/testing/overview/007.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/testing/fabricator/021.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/testing/fabricator/006.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/testing/fabricator/005.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/outgoing/response/026.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/outgoing/localization/008.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/uploaded_files/006.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/curlrequest/014.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/helpers/text_helper/020.php Outdated
@sfadschm
Copy link
Copy Markdown
Contributor Author

sfadschm commented Feb 24, 2022

@kenjis Fixed.
However, I think we should not waist time on fixing CS for the next PRs.
These are just to provide valid PHP syntax, so we can run php-cs-fixer in the last PR to fix all CS violations at once.

@sfadschm
Copy link
Copy Markdown
Contributor Author

sfadschm commented Feb 24, 2022

Coveralls change of "system" should honestly not be touched by this PR 😆

kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/incoming/incomingrequest/10.php Outdated
@sfadschm @kenjis
Fix space.
af4995f 
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/incoming/incomingrequest/13.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/incoming/incomingrequest/15.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/incoming/message/005.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/pagination/011.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/pagination/012.php Outdated
Alex Schmitz and others added 2 commits February 24, 2022 11:33
sfadschm
sfadschm commented Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/outgoing/localization/008.php
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/incoming/incomingrequest/013.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/pagination/012.php
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/sessions/002.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/sessions/005.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/sessions/007.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/sessions/010.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/sessions/014.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/sessions/024.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/sessions/033.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/uploaded_files/004.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/uploaded_files/005.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/uploaded_files/006.php Outdated
kenjis
kenjis reviewed Feb 24, 2022
View reviewed changes
Comment thread user_guide_src/source/libraries/uploaded_files.rst Outdated
@sfadschm @kenjis
Fix UploadedFile instance.
21e7c4e 
Thanks, missed that.

Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
kenjis approved these changes Feb 25, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis merged commit 09cccfb into codeigniter4:develop Feb 25, 2022
@sfadschm sfadschm deleted the docs-non-php-code branch February 25, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfadschm @kenjis