Skip to content

docs: fix coding style by php-cs-fixer#5773

Merged
kenjis merged 3 commits intocodeigniter4:developfrom
kenjis:fix-docs-run-cs-fixer
Mar 8, 2022
Merged

docs: fix coding style by php-cs-fixer#5773
kenjis merged 3 commits intocodeigniter4:developfrom
kenjis:fix-docs-run-cs-fixer

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Mar 4, 2022 •
edited
Loading

Description

Checklist:

  • Needs docs: fix sample code #5774
  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Mar 4, 2022
kenjis
kenjis commented Mar 4, 2022
View reviewed changes
Comment thread user_guide_src/source/general/helpers/005.php Outdated
kenjis
kenjis commented Mar 4, 2022
View reviewed changes
Comment thread user_guide_src/source/outgoing/localization/005.php Outdated
kenjis
kenjis commented Mar 4, 2022
View reviewed changes
Comment thread user_guide_src/source/testing/database/002.php Outdated
kenjis
kenjis commented Mar 4, 2022
View reviewed changes
Comment thread user_guide_src/source/testing/database/002.php Outdated
This was referenced Mar 4, 2022
Merged
Merged
@sfadschm
Copy link
Copy Markdown
Contributor

sfadschm commented Mar 4, 2022

Only few comments, rest looks fine to me 👍

sfadschm
sfadschm reviewed Mar 4, 2022
View reviewed changes
Comment thread user_guide_src/source/database/query_builder/027.php
Comment thread user_guide_src/source/database/query_builder/074.php
Comment thread user_guide_src/source/general/helpers/005.php Outdated
Comment thread user_guide_src/source/helpers/text_helper/007.php
@kenjis
docs: run php-cs-fixer
861f510 
php-cs-fixer fix --verbose --diff --config=.user-guide.php-cs-fixer.dist.php
@kenjis kenjis force-pushed the fix-docs-run-cs-fixer branch from 097e11d to 861f510 Compare March 4, 2022 23:43
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Mar 5, 2022

@sfadschm @paulbalandan I've fixed all commented items.
Anything else?

@sfadschm
Copy link
Copy Markdown
Contributor

sfadschm commented Mar 6, 2022

I am through with all files 👍

@kenjis kenjis requested a review from paulbalandan March 8, 2022 05:45
@kenjis kenjis merged commit 31ca5af into codeigniter4:develop Mar 8, 2022
@kenjis kenjis deleted the fix-docs-run-cs-fixer branch March 8, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

+1 more reviewer

@sfadschm sfadschm sfadschm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @sfadschm @paulbalandan