Skip to content

chore: update composer scripts#5867

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:rename-php-cs-fixer-config-files
Apr 6, 2022
Merged

chore: update composer scripts#5867
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:rename-php-cs-fixer-config-files

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Apr 5, 2022

Description
Follow-up #5866

  • update composer scripts

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

Copy link
Copy Markdown
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a request than a review :) Can we add the --ansi flag to the composer scripts so that output will be colored rather than bland black and white.

@kenjis kenjis force-pushed the rename-php-cs-fixer-config-files branch from 78041ca to ea781ab Compare April 6, 2022 08:23
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Apr 6, 2022

Added --ansi.
On macOS the output is colored, so I didn't know the need.

Copy link
Copy Markdown
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but Composer running these scripts in Windows gives black and white output.

@sfadschm
Copy link
Copy Markdown
Contributor

sfadschm commented Apr 6, 2022

I am on mobile, but I only see one changed file (composer. json). Are the cs-fixer files renamed?

@sfadschm
Copy link
Copy Markdown
Contributor

sfadschm commented Apr 6, 2022

Nevermind, they already were before 😄

@kenjis kenjis merged commit 3efc6cd into codeigniter4:develop Apr 6, 2022
@kenjis kenjis deleted the rename-php-cs-fixer-config-files branch April 6, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants