Skip to content

chore: add "Edit this page" to the userguide latest#5982

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:deploy-userguide-latest-edit-this-page
May 11, 2022
Merged

chore: add "Edit this page" to the userguide latest#5982
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:deploy-userguide-latest-edit-this-page

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented May 9, 2022 •
edited
Loading

Description

Screenshot 2022-05-09 21 15 33

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label May 9, 2022
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented May 9, 2022

The HTML contents I generated locally and the https://codeigniter4.github.io/CodeIgniter4/ are different.
My local HTML has <div role="navigation" aria-label="breadcrumbs navigation">, but the deployed HTML does not have it. Why?

@MGatner
Copy link
Copy Markdown
Member

MGatner commented May 11, 2022

By "deployed" you mean the latest dev version right?

The GitHub Action uses ammaraskar/sphinx-action@0.4 - it's possible that is using a different version of Sphinx than you have installed. I don't know much about Sphinx unfortunately, but that's my best guess.

MGatner
MGatner approved these changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you've tested this.

@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented May 11, 2022

Yes, I tested on my repos.

@kenjis kenjis merged commit 90d7307 into codeigniter4:develop May 11, 2022
@kenjis kenjis deleted the deploy-userguide-latest-edit-this-page branch May 11, 2022 12:20
@neznaika0 neznaika0 mentioned this pull request Feb 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @MGatner