chore: update editorconfig and fix indent in views #6039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --light-bg-color: #ededee; | ||
| --dark-bg-color: #404040; | ||
| --main-bg-color: #fff; | ||
| --main-text-color: #555; |
Member
There was a problem hiding this comment.
Are these diffs generated by Dart SASS?
Member
Author
There was a problem hiding this comment.
No, it is not generated by SASS.
I replaced tabs with spaces manually.
Member
There was a problem hiding this comment.
Ok. It seems kinda weird that they look the same from my PC.
paulbalandan
approved these changes
May 28, 2022
Member
paulbalandan
left a comment
paulbalandan
left a comment
There was a problem hiding this comment.
This is fine with me but let's have others take a look.
MGatner
approved these changes
May 29, 2022
Member
|
Coverage decreased 6.3% 😭 |
Member
Author
|
I don't think this PR changes code coverage. I saw https://coveralls.io/builds/49510047 but I don't get where the decreasing occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6010
Description
Indent the View files with 4 spaces.
The only one exception is
system/Debug/Toolbar/Views/toolbar.css.It is generated by scss and it uses space 2 indentation.
Checklist: