Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented May 17, 2022

Ref codeigniter4/CodeIgniter4#6039

  • update editorconfig
  • use spaces instead of tabs in Views

@kenjis kenjis force-pushed the fix-indent-in-view branch from 903d2a2 to 87fd213 Compare May 18, 2022 12:54
@kenjis kenjis changed the title sttyle: fix indentation in view files style: fix indentation in view files May 19, 2022
@kenjis kenjis force-pushed the fix-indent-in-view branch 2 times, most recently from 2d5c4d7 to f968013 Compare May 19, 2022 21:49
@kenjis kenjis marked this pull request as draft May 24, 2022 23:27
@kenjis kenjis force-pushed the fix-indent-in-view branch from f968013 to 8e3affb Compare May 29, 2022 21:05
@kenjis kenjis marked this pull request as ready for review May 29, 2022 21:06
@kenjis
Copy link
Member Author

kenjis commented May 29, 2022

Now 4 spaces in Views.

@kenjis kenjis requested a review from lonnieezell May 29, 2022 21:07
@kenjis kenjis merged commit 2dc9fd5 into codeigniter4:develop May 30, 2022
@kenjis kenjis deleted the fix-indent-in-view branch May 30, 2022 00:47
@MGatner
Copy link
Member

MGatner commented May 30, 2022

@kenjis How did you apply these changes? Did you open all view files and do a search-and-replace? Or find+sed? Or CS Fixer? I want to use this new style for my projects and I'm trying to decide the best way to apply it.

@kenjis
Copy link
Member Author

kenjis commented May 30, 2022

open all view files and do a search-and-replace.

I think php-cs-fixer does not fix non PHP files.

If you have a lot of files, I recommend you use Formatter like Prettier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants