Skip to content

docs: update repositories.rst#6065

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-docs-repositories.rst
Jun 2, 2022
Merged

docs: update repositories.rst#6065
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:fix-docs-repositories.rst

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Jun 2, 2022

Description

  • update repositories.rst

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jun 2, 2022
:local:
:depth: 2

codeIgniter4 organization
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the lowercased c intended?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, https://github.com/codeigniter4 is lowercased.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I suppose the i should be, too.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I overlooked that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Paul, either all PascalCase or all lower. Rest looks good!

@kenjis kenjis merged commit 6b215f9 into codeigniter4:develop Jun 2, 2022
@kenjis kenjis deleted the fix-docs-repositories.rst branch June 2, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests for documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants