Skip to content

docs: fix how to update next minor upgrade branch#6154

Merged
kenjis merged 2 commits intodevelopfrom
kenjis-patch-1
Jun 23, 2022
Merged

docs: fix how to update next minor upgrade branch#6154
kenjis merged 2 commits intodevelopfrom
kenjis-patch-1

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Jun 18, 2022

Description

  • the step to update local 4.x branch was missing

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault for not looking closely. But I actually recommend working off the repo branches directly for release, as it makes the process faster and reduces mistakes:

Work off direct clones of the repos so the release branches persist for a time

So the upstream remote is irrelevant.

Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't let me suggest a change for untouched lines, but please rework for direct branch access.

@kenjis kenjis requested a review from MGatner June 23, 2022 01:02
@kenjis
Copy link
Copy Markdown
Member Author

kenjis commented Jun 23, 2022

Fixed the git commands.

@kenjis kenjis merged commit fdc4e92 into develop Jun 23, 2022
@kenjis kenjis deleted the kenjis-patch-1 branch June 23, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants