[Rector] Apply Rector run on utils/ directory

[samsonasik]

Apply Rector run on utils/ directory, not only /utils/Rector so other files (PHPStan rules, check_tabs_in_rst.php), will be checked as well.

Checklist:

• Securely signed commits

[kenjis]

@samsonasik Why does Rector remove this PHPDoc?

[samsonasik]

It is @MGatner request to create custom rule to remove var from constant https://github.com/codeigniter4/CodeIgniter4/blob/develop/utils/Rector/RemoveVarTagFromClassConstantRector.php

[MGatner]

A constant is a constant 🤷‍♂️

I do remember that conversation but I'm also fine if we want to revisit this. I think it is unnecessary to type constants but people do it.

[samsonasik]

ref #4766

[kenjis]

It is a common practice to put @var for constants.
I have never seen removing @var for constants.

But at least, PhpStorm does not need @var for constants.
So it does not seem to be inconvenient if it is removed.

[MGatner]

A constant is no longer a constant.

The underlying values may be mutable but it is still a fixed type at runtime. If for some awful reason somebody used your example I would expect a docblock explanation, not a type. Providing @var typing for static analysis is unnecessary because constants are always strongly-typed to whatever they are.

[kenjis]

Yeah, the type is fixed.
But the value is dynamic determined. Very interesting.
https://3v4l.org/dWAaW
I don't know how and when to use it, though.

[MGatner]

Object constants are strange to me. I can't even find the RFC that allowed them for a good example of why someone would want one 🤷‍♂️ To me the power of a constant is it's fixed, simple value.

[MGatner]

Here it is: https://wiki.php.net/rfc/new_in_initializers

Looks like it wasn't deliberately for constants, and is also limited strictly to global constants. The fact that the value for the class constant ends up being dynamic is somewhat of a syntax hack.

[MGatner]

Typed class constants is under discussion for 8.2: https://wiki.php.net/rfc/typed_class_constants