Skip to content

Conversation

@alfstylecat
Copy link

…se check and fix

Each pull request should address a single issue and have a meaningful title.

  • All bug fixes should be sent to the "develop" branch, this is where the next bug fix version will be developed.
  • PRs with any enhancement should be sent to the next minor version branch, e.g. "4.3"

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member

kenjis commented Aug 3, 2022

Thank you for taking time to improve CodeIgniter.

But this PR is not acceptable. Now we use PHP 7.4 or later.
And we use 2_592_000 as our coding style.

See also #6327

@kenjis kenjis closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants