Enable control_structure_braces#6479
Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom Sep 4, 2022
Merged
Conversation
kenjis
approved these changes
Sep 3, 2022
MGatner
approved these changes
Sep 4, 2022
Member
|
These all look good to me. The Config file changes are going to conflict for each of them so I'm fine if you want to roll them up into one or just merge+rebase each on your own. |
Member
Author
|
I'll just rebase each approved. |
51136e0 to
b5929a9
Compare
Member
Author
|
Failing CS fixed in #6491 |
b5929a9 to
50dc13d
Compare
paulbalandan
added a commit
to CodeIgniter/coding-standard
that referenced
this pull request
Sep 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: