Skip to content

tests: increase coverage TableTest#6572

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
ddevsr:test-table-coverage
Sep 23, 2022
Merged

tests: increase coverage TableTest#6572
kenjis merged 2 commits intocodeigniter4:developfrom
ddevsr:test-table-coverage

Conversation

@ddevsr
Copy link
Copy Markdown
Collaborator

@ddevsr ddevsr commented Sep 23, 2022

Description
Implement table test for preg_replace attribute on body row.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Sep 23, 2022
MGatner
MGatner approved these changes Sep 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis merged commit b2dc243 into codeigniter4:develop Sep 23, 2022
@ddevsr ddevsr deleted the test-table-coverage branch September 24, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ddevsr @kenjis @MGatner