test: fix failed MigrationRunnerTest#6612
Merged
kenjis merged 1 commit intocodeigniter4:developfrom Sep 30, 2022
Merged
Conversation
There was 1 failure: 1) CodeIgniter\Database\Migrations\MigrationRunnerTest::testLoadsDefaultDatabaseWhenNoneSpecified Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'.../CodeIgniter4/writable/:memory:' +':memory:' .../CodeIgniter4/tests/system/Database/Migrations/MigrationRunnerTest.php:84
MGatner
approved these changes
Sep 30, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
Looks like this didn't affect GA still 🤷♂️
Member
Author
|
I found the reason. Testing on GA uses a database file. Why not use in-memory database? |
Member
|
Not sure why we aren't using in-memory! It might speed things up a bit, though SQLites3 tests will never be our bottleneck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I don't know why GA check does not fail, but on my local environment the following test always fails.
Checklist: