Skip to content

refactor: _array_search_dot() if conditions#6645

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:refactor-_array_search_dot
Oct 8, 2022
Merged

refactor: _array_search_dot() if conditions#6645
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:refactor-_array_search_dot

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Oct 7, 2022

Description
See https://github.com/codeigniter4/CodeIgniter4/pull/6637/files#r989477123

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Oct 7, 2022
@kenjis kenjis mentioned this pull request Oct 7, 2022
5 tasks
Copy link
Copy Markdown
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks @kenjis

@kenjis kenjis merged commit 84aa31e into codeigniter4:develop Oct 8, 2022
@kenjis kenjis deleted the refactor-_array_search_dot branch October 8, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants